TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix card border issue - apply constraints to Image not Container

Browse Source
This commit is contained in:
laurenspriem
2025-09-03 22:41:53 +05:30
parent 009dec1e08
commit dc843eb618
3 changed files with 24 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
.claude/photo_swipe_culling/card_issue_screenshots/no_swipe_all_good.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 670 KiB

BIN
.claude/photo_swipe_culling/card_issue_screenshots/swipe_and_all_wrong.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 688 KiB

54
mobile/apps/photos/lib/ui/pages/library_culling/widgets/swipeable_photo_card.dart
View File

@@ -157,11 +157,8 @@ class _SwipeablePhotoCardState extends State<SwipeablePhotoCard> {
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
// Let the image size itself, then wrap with decoration
Container(
constraints: BoxConstraints(
maxWidth: maxWidth,
maxHeight: maxHeight,
),
decoration: BoxDecoration(
borderRadius: BorderRadius.circular(16),
boxShadow: [
@@ -171,38 +168,35 @@ class _SwipeablePhotoCardState extends State<SwipeablePhotoCard> {
offset: const Offset(0, 5),
),
],
// Apply border directly when swiping
border: borderColor != null && borderWidth > 0
? Border.all(
color: borderColor,
width: borderWidth,
)
: null,
),
child: ClipRRect(
borderRadius: BorderRadius.circular(16),
child: Stack(
children: [
// Main photo - progressively load from thumbnail to full image
if (_imageProvider != null)
Image(
image: _imageProvider!,
fit: BoxFit.contain,
gaplessPlayback: true,
child: _imageProvider != null
? ConstrainedBox(
constraints: BoxConstraints(
maxWidth: maxWidth,
maxHeight: maxHeight,
),
child: Image(
image: _imageProvider!,
fit: BoxFit.contain,
gaplessPlayback: true,
),
)
else
const Center(
child: EnteLoadingWidget(),
),
// Border overlay for swipe feedback
if (borderColor != null && borderWidth > 0)
IgnorePointer(
child: Container(
decoration: BoxDecoration(
border: Border.all(
color: borderColor,
width: borderWidth,
),
borderRadius: BorderRadius.circular(16),
),
: SizedBox(
width: maxWidth * 0.8,
height: maxHeight * 0.5,
child: const Center(
child: EnteLoadingWidget(),
),
),
],
),
),
),
// File info directly below the image