TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: bypass interaction check for manual stream requests

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Prateek Sunal
2025-08-27 13:00:21 +00:00
parent 84a5ad0b86
commit ecca4c3dc8
2 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
mobile/apps/photos/lib/services/machine_learning/compute_controller.dart
View File

@@ -70,10 +70,14 @@ class ComputeController {
_logger.info('init done ');
}
bool requestCompute({bool ml = false, bool stream = false}) {
_logger.info("Requesting compute: ml: $ml, stream: $stream");
if (!_isDeviceHealthy || !_canRunGivenUserInteraction()) {
_logger.info("Device not healthy or user interacting, denying request.");
bool requestCompute({bool ml = false, bool stream = false, bool bypassInteractionCheck = false}) {
_logger.info("Requesting compute: ml: $ml, stream: $stream, bypassInteraction: $bypassInteractionCheck");
if (!_isDeviceHealthy) {
_logger.info("Device not healthy, denying request.");
return false;
}
if (!bypassInteractionCheck && !_canRunGivenUserInteraction()) {
_logger.info("User interacting, denying request.");
return false;
}
bool result = false;

19
mobile/apps/photos/lib/services/video_preview_service.dart
View File

@@ -131,7 +131,7 @@ class VideoPreviewService {
// Start processing if not already processing
if (uploadingFileId < 0) {
queueFiles(duration: Duration.zero);
queueFiles(duration: Duration.zero, isManual: true);
} else {
_items[file.uploadedFileID!] = PreviewItem(
status: PreviewItemStatus.inQueue,
@@ -252,13 +252,15 @@ class VideoPreviewService {
BuildContext? ctx,
EnteFile enteFile, [
bool forceUpload = false,
bool isManual = false,
]) async {
if (!_allowStream()) {
final canStream = isManual ? _allowManualStream() : _allowStream();
if (!canStream) {
_logger.info(
"Pause preview due to disabledSteaming($isVideoStreamingEnabled) or computeController permission)",
"Pause preview due to disabledSteaming($isVideoStreamingEnabled) or computeController permission) - isManual: $isManual",
);
if (isVideoStreamingEnabled) _logger.info("No permission to run compute");
clearQueue();
if (!isManual) clearQueue(); // Only clear queue for automatic processing
return;
}
@@ -1124,11 +1126,16 @@ class VideoPreviewService {
computeController.requestCompute(stream: true);
}
void queueFiles({Duration duration = const Duration(seconds: 5)}) {
bool _allowManualStream() {
return isVideoStreamingEnabled &&
computeController.requestCompute(stream: true, bypassInteractionCheck: true);
}
void queueFiles({Duration duration = const Duration(seconds: 5), bool isManual = false}) {
Future.delayed(duration, () async {
if (_hasQueuedFile) return;
final isStreamAllowed = _allowStream();
final isStreamAllowed = isManual ? _allowManualStream() : _allowStream();
if (!isStreamAllowed) return;
await _ensurePreviewIdsInitialized();