[server] Minor bug fixes in embedding/files API

This commit is contained in:
Neeraj Gupta
2024-03-19 06:15:55 +05:30
parent c564e50d59
commit f0236acf8f
3 changed files with 4 additions and 3 deletions

View File

@@ -53,7 +53,7 @@ func (h *EmbeddingHandler) GetDiff(c *gin.Context) {
// GetFilesEmbedding returns the embeddings for the files
func (h *EmbeddingHandler) GetFilesEmbedding(c *gin.Context) {
var request ente.GetFilesEmbeddingRequest
if err := c.ShouldBindQuery(&request); err != nil {
if err := c.ShouldBindJSON(&request); err != nil {
handler.Error(c,
stacktrace.Propagate(ente.ErrBadRequest, fmt.Sprintf("Request binding failed %s", err)))
return

View File

@@ -4,6 +4,7 @@ import (
"context"
"database/sql"
"fmt"
"github.com/lib/pq"
"github.com/ente-io/museum/ente"
"github.com/ente-io/stacktrace"
@@ -58,7 +59,7 @@ func (r *Repository) GetDiff(ctx context.Context, ownerID int64, model ente.Mode
func (r *Repository) GetFilesEmbedding(ctx context.Context, ownerID int64, model ente.Model, fileIDs []int64) ([]ente.Embedding, error) {
rows, err := r.DB.QueryContext(ctx, `SELECT file_id, model, encrypted_embedding, decryption_header, updated_at
FROM embeddings
WHERE owner_id = $1 AND model = $2 AND file_id = ANY($3)`, ownerID, model, fileIDs)
WHERE owner_id = $1 AND model = $2 AND file_id = ANY($3)`, ownerID, model, pq.Array(fileIDs))
if err != nil {
return nil, stacktrace.Propagate(err, "")
}

View File

@@ -71,7 +71,7 @@ func FindMissingElementsInSecondList(sourceList []int64, targetList []int64) []i
targetSet[item] = struct{}{}
}
var missingElements []int64
var missingElements = make([]int64, 0)
for _, item := range sourceList {
if _, found := targetSet[item]; !found {
missingElements = append(missingElements, item)