TerribleDev/ente
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[mob][photos] Properly handle and log error/exception thrown in isolate (#5234)

Browse Source
This commit is contained in:
Ashil
2025-03-06 15:24:54 +05:30
committed by GitHub
parent 4bd08f02f8 ff82245293
commit fcc249b989
1 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
mobile/lib/services/local/local_sync_util.dart
View File

@@ -34,17 +34,26 @@ Future<Tuple2<List<LocalPathAsset>, List<EnteFile>>> getLocalPathAssetsAndFiles(
if (assetsInPath.isEmpty) {
result = const Tuple2({}, []);
} else {
result = await Computer.shared().compute(
_getLocalIDsAndFilesFromAssets,
param: <String, dynamic>{
"pathEntity": pathEntity,
"fromTime": fromTime,
"alreadySeenLocalIDs": alreadySeenLocalIDs,
"assetList": assetsInPath,
},
taskName:
"getLocalPathAssetsAndFiles-${pathEntity.name}-count-${assetsInPath.length}",
);
try {
result = await Computer.shared().compute(
_getLocalIDsAndFilesFromAssets,
param: <String, dynamic>{
"pathEntity": pathEntity,
"fromTime": fromTime,
"alreadySeenLocalIDs": alreadySeenLocalIDs,
"assetList": assetsInPath,
},
taskName:
"getLocalPathAssetsAndFiles-${pathEntity.name}-count-${assetsInPath.length}",
);
} catch (e) {
_logger.severe("_getLocalIDsAndFilesFromAssets failed", e);
_logger.info(
"Failed for pathEntity: ${pathEntity.name}",
);
rethrow;
}
alreadySeenLocalIDs.addAll(result.item1);
uniqueFiles.addAll(result.item2);
}
@@ -299,12 +308,8 @@ Future<Tuple2<Set<String>, List<EnteFile>>> _getLocalIDsAndFilesFromAssets(
(fromTime / ~1000);
if (!alreadySeenLocalIDs.contains(entity.id) &&
assetCreatedOrUpdatedAfterGivenTime) {
try {
final file = await EnteFile.fromAsset(pathEntity.name, entity);
files.add(file);
} catch (e) {
_logger.severe(e);
}
final file = await EnteFile.fromAsset(pathEntity.name, entity);
files.add(file);
}
}
return Tuple2(localIDs, files);