e.g. see a recent build failures:
https://github.com/ente-io/photos-desktop/actions/runs/8996782367/job/24713793588
there was another one recently. both of these were on the Windows runner, in one
case the message was:
info There appears to be trouble with your network connection. Retrying...
in another case the issue manifested later
D:\a\photos-desktop\photos-desktop\web\node_modules\date-fns\formatISO\index.js:11
/**
SyntaxError: Invalid or unexpected token
at internalCompileFunction (node:internal/vm:128:18)
at wrapSafe (node:internal/modules/cjs/loader:1280:20)
but retrying fixed it, so I'm counting it as a broken package install.
The environment variables we are passing get picked by the built in notarization
code in electron-builder which signs successfully.
notarization successful
But thereafter electron-builder-notarize starts throwing some errors:
Error: The appleIdPassword property is required when using notarization with password credentials
at validateNotaryToolAuthorizationArgs (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-notarize/src/validate-args.ts:107:13)
Skipping notarization: The appleIdPassword property is required when using notarization with appleId
at module.exports (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-builder-notarize/validate.js:42:18)
Since the notarization has already happened, we don't need this
From build logs:
• notarization successful
Error: The appleIdPassword property is required when using notarization with password credentials
at validateNotaryToolAuthorizationArgs (/Users/runner/work/photos-desktop/photos-desktop/desktop/node_modules/electron-notarize/src/validate-args.ts:107:13)
Not sure, but at the face of it (since this was not enabled earlier too), our
notarization process kicks in during signing because of the presence of env
vars, and specifying it again here starts a separate process we haven't
configured.
