Commit Graph

24606 Commits

Author SHA1 Message Date
Manav Rathi
96ea53face preload / watch - part 1
The change event was not being used (since
dca542e781), so also remove that dead code.
2024-03-25 13:31:28 +05:30
Manav Rathi
67468c6ff9 Move the selection dialogs 2024-03-25 13:02:06 +05:30
Manav Rathi
e8acbd8c9f Convert the other conversion functions 2024-03-25 12:45:21 +05:30
Manav Rathi
2522da2b5e Handle runFFMPEGCmd in preload 2024-03-25 12:32:57 +05:30
Manav Rathi
dd7e87274a Handle set/getEncryptionKey in preload 2024-03-25 12:19:19 +05:30
Manav Rathi
106ba270fe Handle ML related functions in updated preload 2024-03-25 12:09:11 +05:30
Ashil
ed4886a6a5 [mobile][photos] Fix performance benchmarking config (#1195)
## Description

- Fix broken integration test used for benchmarking gallery scroll
performance.
- Automate email and password entry.
- Write script to run perf test.
2024-03-25 10:30:13 +05:30
Vishnu Mohandas
bdd6663461 [auth] custom icons (#1194)
Edited the custom-icons.json for the added SVG files.
2024-03-25 10:17:11 +05:30
ludespeedny
a403cd88e2 custom icons for DCS, WYZE 2024-03-24 12:20:28 -04:00
ludespeedny
d11ee7acb4 Update custom-icons.json
update custom-icons.json for DCS and WYZE icons.
2024-03-24 12:18:33 -04:00
Vishnu Mohandas
f3bdfa84ef [docs] Collapse the Migration guide for Auth 2024-03-23 21:06:35 +05:30
Manav Rathi
4bf99c8bea [photos-desktop] Fix preload.ts - Part x/x (#1190)
Continuation of https://github.com/ente-io/ente/pull/1189
2024-03-23 20:44:41 +05:30
Manav Rathi
d3093809d6 Inline more into preload 2024-03-23 20:25:56 +05:30
Manav Rathi
81ba5379c9 Move checkExistsAndCreateDir out of preload 2024-03-23 20:06:27 +05:30
Manav Rathi
f21dc84840 Switch to async fs.exists
We cannot expose the sync version over the context bridge - the node:fs module
is not available to the preload script under context isolation.
2024-03-23 19:59:47 +05:30
Manav Rathi
b1d0909675 EXtract common queueProcessor 2024-03-23 18:49:22 +05:30
Manav Rathi
7704b902c4 Extract shared function 2024-03-23 18:46:20 +05:30
Manav Rathi
bdb2a22863 Extract shared function 2024-03-23 18:44:30 +05:30
Manav Rathi
47a7042d55 Remove dead code from cast 2024-03-23 18:38:31 +05:30
Manav Rathi
a5c3aff54b Expose an fs.exists over the context bridge 2024-03-23 18:28:22 +05:30
Manav Rathi
120edbbc65 [photos-desktop] Fix preload.ts - Part x/x (#1189)
- Refactor towards making preload.ts self contained (see comments at the
top of the file why)
- More PRs in this series will come
- Build is still broken
2024-03-23 16:17:23 +05:30
Manav Rathi
7a3209ebf6 Fix preload.ts - Part x/x 2024-03-23 16:13:16 +05:30
Manav Rathi
efa49bd2b0 [web] New translations (#1187)
New translations from
[Crowdin](https://crowdin.com/project/ente-photos-web)
2024-03-23 16:11:29 +05:30
Crowdin Bot
e953c1c16b New Crowdin translations by GitHub Action 2024-03-23 10:40:49 +00:00
Manav Rathi
f7d2b735f9 [crowdin] Invalidate existing translations when source strings change (#1188)
Don't upload existing translation when syncing with Crowdin. This way,
we let the existing translations be invalidated when we change the
source string (this was not happening previously since we also upload
the (older) translations when
we upload the changed source strings).

**Tested by**

Doing this on a different test branch, changing a source string,
manually running the workflow against that branch, and verifying that
the strings are getting reset in the PR that Crowdin' action opens.
2024-03-23 15:28:29 +05:30
Manav Rathi
bbeac2bdf0 [crowdin] Invalidate existing translations when source strings change
Don't upload existing translation when syncing with Crowdin. This way, we let
the existing translations be invalidated when we change the source string (this
was not happening previously since we also upload the (older) translations when
we upload the changed source strings).
2024-03-23 15:26:34 +05:30
Manav Rathi
517ee0914c [web] Update the "source" translation (#1186)
https://github.com/ente-io/ente/pull/1185 updated the file but in the
accounts app. That's not the file that's used as the source - this PR
updates the one we use as the source for Crowdin.
2024-03-23 15:03:15 +05:30
Manav Rathi
53c53cebbc [web] Update the "source" translation
https://github.com/ente-io/ente/pull/1185 updated the file but in the accounts
app. That's not the file that's used as the source - this PR updates the one we
use as the source for Crowdin.
2024-03-23 15:01:44 +05:30
Vishnu Mohandas
d673537110 Fix cases (#1185)
## Description
The intent was to lower the case for "Files" and "Each" (that were in
caps), since the file was open, also ended up flipping the case for
"ente".

## Tests
Have verified the places "files" and "each" were being printed. As for
"Ente", the change should not cause any side effects.
2024-03-23 14:54:20 +05:30
vishnukvmd
0fd4b2936d ente -> Ente 2024-03-23 12:22:16 +05:30
vishnukvmd
a96cb58f87 Fix case for strings 2024-03-23 12:20:15 +05:30
Manav Rathi
2de4e51c7b [photos-desktop] Disable node integration - Part x/x (#1181)
Continuing in the series of refactorings, working towards disabling node
integration in the photos desktop app.
2024-03-22 21:06:01 +05:30
Manav Rathi
d297465ea6 Dedup 2024-03-22 20:48:57 +05:30
Manav Rathi
0fdb2fb357 Fix type errors in fs.ts 2024-03-22 20:01:02 +05:30
Manav Rathi
6c8f4185f7 Fix error in clipService 2024-03-22 19:56:36 +05:30
Manav Rathi
31ad9a3eb3 Document that the main process is not restarted 2024-03-22 19:55:57 +05:30
Manav Rathi
0a7991bc0e Remove unused code 2024-03-22 19:52:08 +05:30
Manav Rathi
302b9a46b5 [photo-desktop] Rely heavier on local Electron cache (#1178)
Remove the special disk only cache we had when running under Electron,
and instead rely on the "disk-cache-size" flag to get the embedded
Chromium in our app to cache more generously.

This change is being done to reduce the surface area of the APIs we need
to migrate to in a post no-node-integration world.
2024-03-22 17:54:30 +05:30
Manav Rathi
68fe6f45c4 Validate that getPath is not throwing 2024-03-22 17:54:02 +05:30
Manav Rathi
03bad54bce Remove from the web side 2024-03-22 17:41:32 +05:30
Manav Rathi
3dbf82552d Use the web native cache only - desktop side changes 2024-03-22 17:28:05 +05:30
Manav Rathi
22e57669fb [photos-desktop] Disable node integration - Part x/x (#1176)
This continues the refactoring to disable node integration in our
rendered process. The code is still in a WIP state, and more PRs in this
series will come.
2024-03-22 16:06:16 +05:30
Manav Rathi
193c8d8899 Fix an error in the order of the arguments for imagemagick (#1175)
## Description

When importing a folder, I am getting this error on each image:
```
  cmd: "'/tmp/.mount_ente-xHvuBzN/resources/image-magick' -auto-orient -define 'jpeg:size=1440x1440' 'IMG_9694.heic' -thumbnail '720x720>' -unsharp '0x.5' -quality 70 '/tmp/ente/E6YH91g3T3-thumb.jpeg'",
  stdout: '',
  stderr: "magick: no images found for operation `-auto-orient' at CLI arg 1 @ error/operation.c/CLIOption/5432.\n"
```

## Tests

This is UNTESTED because I don't have a build env ready, however it
seems like this error is coming out because we pass the input file after
specifying some modifier flag that applies to it, and we should put the
input before.
2024-03-22 16:03:10 +05:30
Manav Rathi
f083f0633d Remove electron-reload
It reloads the BrowserWindow, but that already has HMR since we're connecting to
a Next dev server on localhost.

What we want is the main process to reload if the files for the main process are
changed. All options I've found so far just restart the main app on changes to
the main process code. I'm not sure that'll be useful, so not adding them right
now (and in any case, this is not a regression, it just wasn't working with
electron-reload either). For future reference if I need to revisit this, these
are the things I scouted:

- https://www.electronforge.io/config/plugins/webpack
- https://github.com/sindresorhus/electron-reloader
- https://electron-vite.org/guide/hot-reloading.html
2024-03-22 15:55:25 +05:30
Manav Rathi
f2c288bdab Remove promise-fs
Unnecessary, and unmaintained (since now node offers it natively)
2024-03-22 15:54:18 +05:30
Mathieu Velten
87de9e2afa Fix an error in the order of the arguments for imagemagick 2024-03-22 11:21:36 +01:00
Manav Rathi
1830a1b931 Let fs.readFile throw on non-existent files 2024-03-22 15:39:05 +05:30
Manav Rathi
b6b4ee7e3a recursive: true is mkdir -p 2024-03-22 15:31:45 +05:30
Manav Rathi
c41bb571f6 Convert more promise-fs 2024-03-22 15:23:41 +05:30
Manav Rathi
94ac21950d Convert to Electron's native fetch 2024-03-22 15:21:27 +05:30